jnthas / clockwise

do-it-yourself, full-featured and smart wall clock device
https://clockwise.page
MIT License
263 stars 34 forks source link

Feature Request: Allow setting custom NTP servers #29

Closed TheGroundZero closed 1 year ago

TheGroundZero commented 1 year ago

I prefer to keep IoT devices on a non-internet VLAN where possible. I also run my own NTP server on the local network and communicate its address via DHCP to clients.

It would be nice to be able to configure my own NTP server either in the Settings page or have the device follow the DHCP options for NTP servers.

TheGroundZero commented 1 year ago

I'm working on this in a fork, but I'm not used to working with ArduinoIDE. So I'm looking to incorporate this: https://github.com/ropg/ezTime#setserver-and-setinterval

TheGroundZero commented 1 year ago

Can anyone try to compile this and check if it works? https://github.com/TheGroundZero/clockwise/commit/8a1e3f3c9b47f95e3bde1d3aa69961591d40ffe9

jnthas commented 1 year ago

@TheGroundZero it was a great first attempt. It almost work at first. I made some changes in your fork I would like to push the changes, I think you have to PR first

TheGroundZero commented 1 year ago

@jnthas I've initiated the PR and marked it as editable by the maintainer