jnthnclrk / warrick

Automatically exported from code.google.com/p/warrick
0 stars 0 forks source link

MP3s corrupted during recovery #9

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. recovered site with mp3s
2.
3.

What is the expected output? What do you see instead?
mp3 files still played, but were corrupted.

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by jbrunell...@gmail.com on 5 Sep 2012 at 10:42

GoogleCodeExporter commented 8 years ago
I think it has something to do with branding removal. Warrick treats an 
unspecified file as a regular text file and attempts to remove branding from 
it. I tested this by quickly disabling the function removebranding() in 
"warrick.pl". After the fix, I was able to recover a test file (a zip) off my 
old site, and I found no corruption in it. But with the removebranding() 
enabled, the zip contains checksum errors.

Original comment by oliver.m...@gmail.com on 8 Dec 2012 at 3:20

GoogleCodeExporter commented 8 years ago
There seems to be more issues with branding removal. I don't do perl or regexp, 
so I have no idea how to fix these. I might consider tinkering with the 
script... Maybe I'll find a way to make Warrick more co-operative with Internet 
Archive.

Original comment by oliver.m...@gmail.com on 8 Dec 2012 at 3:24

GoogleCodeExporter commented 8 years ago
Well, here's the updated version. It's relatively untested, but seems to do the 
job pretty well. I'm not exactly sure if I introduced any bugs while patching 
it, as I can't code Perl, although I do other "C-like" languages. I do honestly 
think that the new version is better in many ways. 

I call it simply "version 2.2.2", but as you know, it really isn't an official 
patch, so no support should be expected from the real developers. But devs, 
feel free to integrate the fixes in your official version(s). I commented the 
list of changes in the source.

To use this version (with fixed file handling and other patches), just replace 
your latest 2.2.1 version 'warrick.pl' with this one. Keep the 2.2.1 version 
just in case.

I attached the fixed 'warrick.pl' here. Alternatively, you can download it from:

http://omolini.steptail.com/warrick/warrick.pl

Regards.

Original comment by oliver.m...@gmail.com on 12 Dec 2012 at 7:30

Attachments:

GoogleCodeExporter commented 8 years ago
Oh yeah, post comments if you find the fixes useful. Contact me at 
oliver'at'steptail.com if you need more info.

Original comment by oliver.m...@gmail.com on 12 Dec 2012 at 7:38

GoogleCodeExporter commented 8 years ago

Original comment by jbrunell...@gmail.com on 28 May 2013 at 6:42