Design Docs Review

[vawhitehouse]

MVP Review

• [x] MVP 2: should include login/logout functionality
• [x] Businesses: is this just a show page? or can users create businesses?
• [x] Reviews: can a user delete their review? You need CRUD functionality for at least one MVP - reviews are probably a good place for that!

Schema

• [x] Every table should have created_at/updated_at columns with data type of datetime
• [x] You may want to check if all not null constraints are needed - eg, I don't think business are required to have url on yelp
• [x] Be sure you denote any foreign keys and index them

Sample State

• [x] Add some formatting to state
• [x] businesses will need to keep track of their reviews with an array of ids
• [x] Users will need to store their review ids

Backend Routes

• [x] Need a / route
• [x] Will you need a user show route?
• [x] You may want to next reviews be a nested route under businesses

Frontend Routes

• [x] Add some formatting (indentation) to demonstrate any components being rendered within another component or multiple components being rendered under the same route
• [x] Add any frontend routes/components that will be needed for businesses

Let me know if you have any questions! We can talk more about this when we meet one-on-one.

[vawhitehouse]

NIce job with the updates so far! Here are a couple more things:

MVPs

• [ ] My previous comment on if users can create businesses was a genuine question. If this is something you want implement, great! But I think you could have this be a bonus feature and just use seeded businesses for now.

Sample State

• [ ] Frontend state should use camelCase
• [ ] Entire state object should be in one code block (it looks like you have several code blocks)

Backend Routes

• [ ] I think you'll want to next your review index route under businesses. Checkout this reading on nested routing: https://github.com/appacademy/curriculum/blob/master/rails/readings/routing-part-ii.md.

Other

• [ ] Update your Github repo to be the name of your clone