jnunemaker / crack

Really simple JSON and XML parsing, ripped from Merb and Rails.
MIT License
541 stars 93 forks source link

Use GitHub actions #76

Closed kiskoza closed 9 months ago

kiskoza commented 10 months ago

I was doing some maintanence tasks for an other gem and when I added the new Ruby 3.3 to the CI pipeline, I saw a few deprecation warnings coming from this gem (as one of our dependencies). I saw that there's a PR already to get rid of the warning (#75), but the project lacks of a working pipeline to verify that change (travis seems to be unavailable). Looking at the open pull requests, there were others trying to make sure that the gem works with recent Ruby versions (#74, #71).

Fast-forward to my PR: I'm trying to add Github Actions as it seems to be a reliable pipeline for open source repositories hosted on Github.

The changes I made:

I hope you'll find this PR helpful. Let me know if you need anything else before you can merge it in.

(edit) And example of a green pipeline could be found here https://github.com/kiskoza/crack/actions/runs/7384963412

bf4 commented 9 months ago

@kiskoza You've been granted the respect and responsibility of a maintainer by myself and @jnunemaker :) Thanks for your assistance!