backtick code symbols, fix grammar/spelling

jnunemaker / httparty

:tada: Makes http fun again!

MIT License

5.79k stars 968 forks source link

backtick code symbols, fix grammar/spelling #753

Closed LoganBarnett closed 2 years ago

LoganBarnett commented 2 years ago

The #670 pull request has a few asks for improvements. This addresses all of those improvements and makes some additional grammatical and formatting adjustments in spirit of the PR feedback.

The ActiveSupport::to_params has been substituted for HTTParty::HashConversinos.to_params since the PR comment hinted at that, and a quick search pulled that up. Maybe it's inaccurate though - feel free to correct.

LoganBarnett commented 2 years ago

If y'all prefer, we could just retarget this to master too. I don't have a strong preference here.

I came to the project looking for documentation and found what I was looking for in the PR. I figure maybe those quick tweaks would've put this back on track for getting merged :)

Thanks for maintaining this awesome library!

TheSmartnik commented 2 years ago

@LoganBarnett good job, thanks! I completely forgot about this pr, should probably finish it up. It's been 3 years already 😅