Add CSV gem as a dependency for Ruby 3.4

jnunemaker / httparty

:tada: Makes http fun again!

MIT License

5.81k stars 964 forks source link

Add CSV gem as a dependency for Ruby 3.4 #796

Closed ngan closed 8 months ago

ngan commented 8 months ago

In Ruby 3.4, the csv gem will not be a default gem. Since httparty uses CSV directly, we should add it as a gem dependency.

/usr/local/bundle/ruby/3.3.0/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

ngan commented 8 months ago

@jnunemaker friendly bump. Let me know if there's anything else to be done for this. Thanks!