jnunemaker / httparty

:tada: Makes http fun again!

MIT License

5.79k stars 968 forks source link

csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0 #797

Closed diei closed 4 months ago

diei commented 6 months ago

After update to Ruby 3.3.0 I get following information:

~/.rvm/gems/ruby-3.3.0/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

wmanica commented 5 months ago

Here for the same reason. Other gems have resolved adding the gems to the gemspec, in this case csv.

here an example: https://github.com/thinreports/thinreports-generator/pull/134/files

mishina2228 commented 4 months ago

796 has already been merged, so all that remains is for the new version to be released.

jnunemaker commented 4 months ago

Whoops! I thought I released new version. Looks like I forgot. I'll do that now.

jnunemaker commented 4 months ago

0.22 is out.

krystof-k commented 4 months ago

Just an observation regarding this: this possibly breaks using the existing default gem without require "csv" for everyone with this gem in dependencies (uninitialized constant SomeClass::CSV) – I guess in Rails only.

wJoenn commented 3 months ago

@krystof-k can you explain how come Rails is not requiring the "csv" gem that is now in our Gemfile like it does with any other gem ? 🤔

krystof-k commented 3 months ago

@wJoenn I have no idea. Rails 🪄🎩.