search

jnv / ansible-role-unattended-upgrades

[DEPRECATED] Setup unattended-upgrades on Debian-based systems
https://github.com/jnv/ansible-role-unattended-upgrades/issues/98
GNU General Public License v2.0
272 stars 94 forks source link

Moved configuration into a new file that doesn't overwrite default settings #66

Closed colans closed 2 years ago

colans commented 5 years ago

See #32 for details.

jnv commented 5 years ago

This is awesome, thank you Colan! I would like to bundle this change along with other breaking changes into next major release, I will prepare a new branch and include your PR there.

colans commented 3 years ago

@jnv It's now been over a year. Would you have some time to merge this, and ideally cut a new release on Galaxy? Thanks! Just noticed the conflicts. I'll take a look at them.

jnv commented 3 years ago

Thanks! I would like to first move the testing infra from Travis to GitHub Actions, I'll try to find a time for this next week.

colans commented 3 years ago

This should now be good to go, assuming all checks are successful. If you're cool with this, @jnv , this should also close #32. There's additional discussion in there, but I don't believe it does anything more for us.

(I can't speak to GitHub Actions; we do everything in GitLab.com's CI. In fact, I haven't even been on GitHub in a while now and it looks like there's no way to refer to an MR in a commit message, or as they call them here, PRs ;)

colans commented 3 years ago

@jnv Any chance you can merge this soon, and close #32 ? Thanks!

iamdevnull commented 3 years ago

It would be great if this could be merged plz.

Thx

jnv commented 2 years ago

Hey, sorry for ignoring this for so long, I have many other things going on and don't use this role so this is very low on my list of priorities.

The PR looks good, however I am afraid of introducing regressions. There's a WIP branch there I'd like to migrate tests away from Travis to GitHub actions with Molecule: #84. If someone could help me to push this forward.

I think I could also merge this and push it into a pre-release to finally unblock it.

jnv commented 2 years ago

I am closing this PR since this role has been deprecated. Feel free to suggest alternatives in #98.

colans commented 2 years ago

I requested that this be merged via the issue in the new project @ https://github.com/hifis-net/ansible-role-unattended-upgrades/issues/10.