search

jnv / ansible-role-unattended-upgrades

[DEPRECATED] Setup unattended-upgrades on Debian-based systems
https://github.com/jnv/ansible-role-unattended-upgrades/issues/98
GNU General Public License v2.0
272 stars 94 forks source link

Use minimal steps by default #67

Closed dnrce closed 4 years ago

dnrce commented 4 years ago

This is a saner default and unattended-upgrades made the switch as of version 0.95 in August 2017: https://github.com/mvo5/unattended-upgrades/commit/16fb837e0485e49fba537a7c11ee144ef9d1a4cc

Unfortunately, that switch means the role is currently unable to set this to false because when configured to false the setting is omitted.

This PR does two things:

  1. Updates the default to match current behavior; and
  2. Fixes the ability to specify the behavior either way.

I'm happy to split those changes up if they're not both welcome.

dnrce commented 4 years ago

I realized the initial version of this PR (which used {% if unattended_minimal_steps %}) was problematic because it changed it from being unable to set this to false for current packages to being unable to set it to true for older packages. 🙄I pushed a quick change but need to do another update after some further local testing -- without digging in yet I suspect a case issue with True vs. true.

dnrce commented 4 years ago

That was indeed the issue. Updated PR.

jnv commented 4 years ago

Makes sense, thanks for PR!

dnrce commented 4 years ago

Thanks for the review and merge -- and for this role!