search

jnv / ansible-role-unattended-upgrades

[DEPRECATED] Setup unattended-upgrades on Debian-based systems
https://github.com/jnv/ansible-role-unattended-upgrades/issues/98
GNU General Public License v2.0
272 stars 94 forks source link

Add the ansible_managed string at beginning of the deployed files #70

Closed jkirk closed 4 years ago

jkirk commented 4 years ago

The ansible_managed string is only added if unattended_ansible_header is true, which is currently default.

Closes: jnv/ansible-role-unattended-upgrades#69

jnv commented 4 years ago

Hi Darshaka and thanks for the PR! I have specifically avoided this variable in the past because it used to contain current time and modified the file on every run. Looks like this has been changed some time ago so it should be safe to add it.

Personally I wouldn't mind having it in the files by default since it is not a breaking change (or shouldn't be if your setup isn't completely messed up). So perhaps could you remove unattended_ansible_header variable and just put // {{ ansible_managed }} to templates unconditionally? Just make sure there's an empty line after it.

jnv commented 4 years ago

By the way I have fixed the failing CI, feel free to rebase.