search

jnv / ansible-role-unattended-upgrades

[DEPRECATED] Setup unattended-upgrades on Debian-based systems
https://github.com/jnv/ansible-role-unattended-upgrades/issues/98
GNU General Public License v2.0
272 stars 94 forks source link

fix: unattended-upgrades stops when powermgmt-base is missing #74

Closed jbe-dw closed 2 years ago

jbe-dw commented 4 years ago

On some systems unattended-upgrades fails or silently fails with this message:

Unattended upgrade result: Upgrade was interrupted
Unattended-upgrades log:
Checking if system is running on battery is skipped. Please install
powermgmt-base package to check power status and skip installing updates
when the system is running on battery.

Installing it as a prerequisite solves the issue.

jnv commented 4 years ago

Thanks for the PR, but this seems like an issue which should be solved in upstream so I am hesitant to accept this. Could you please provide more information? What systems are affected? Was this actually reported or discussed in upstream or on bug trackers of respective distributions affected by this issue?

smutel commented 4 years ago

Currently the package powermgmt-base is a suggested to be installed, not a real dependency => https://packages.debian.org/buster/unattended-upgrades.

What about adding an option to install this package or not. Installation will be false by default ?

jnv commented 4 years ago

What about adding an option to install this package or not. Installation will be false by default ?

Yeah, I would be okay with this as long as it is cross-distro compatible.

Do you think it would make sense to install thi dependency with some particular options, e.g. the one you added in #76?

jnv commented 4 years ago

Or it could be just a documented behavior, it's not like this role needs an option for everything especially if you can solve it with a single task...

smutel commented 4 years ago

I updated #76 to install this package.

jnv commented 2 years ago

I am closing this PR since this role has been deprecated. Feel free to suggest alternatives in #98.