search

jnweiger / led-name-badge-ls32

Upload tool for an led name tag with USB-HID interface
GNU General Public License v2.0
230 stars 86 forks source link

Add more icons and animations #39

Open mbr-sn opened 1 year ago

mbr-sn commented 1 year ago

Can we add some more icons and animations to the gfx folder? Attached is one I created, feel free to add it to the code, share and enjoy. python3 ./led-badge-11x44.py -s4 -m5 :gfx/animated_alien_48x11.png:

animated_alien_48x11

s-light commented 1 year ago

if you open a pull-request and ensure the icon is drawn by yourself i think we can merge this. @jnweiger any doubts?

jnweiger commented 1 year ago

That is a nice one! Yes, as @s-light says, the only 'obstacle' is copyright and licensing. We need to know if you created this yourself, or from where it came, and under which license we would be able to use it. If it's your own design, any you don't have any specific requirments, I suggest that you pick the same license that we use for the rest of this project, GPLv2: https://github.com/jnweiger/led-name-badge-ls32/blob/master/LICENSE

mbr-sn commented 1 year ago

It is obviously inspired by old arcade games, but I drew it myself from scratch pixel by pixel, so I guess copyright is not an issue (ianal though). Permission is hereby granted with the same license as the rest of the code, GPLv2. :-)

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11. But one must not use the rightmost 4 columns, otherwise they "wrap around" to the left side of the display, it's a bit confusing at first. So I thought sharing an example would be nice for demo purposes.

Image Magick is a useful tool by the way to split and merge the frames.

ManInDark commented 1 year ago

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11

I'd appreciate if that were to be mentioned in the README, as this is crucial information.

jnweiger commented 1 year ago

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11

I'd appreciate if that were to be mentioned in the README, as this is crucial information.

Animations weren't mentioned in the README add all. Added https://github.com/jnweiger/led-name-badge-ls32/commit/b23c84a79334e8a1ace95a0fef8618be1dcc636e