Endpoints for file uploads should be improved

[fazpu]

For example, the swagger:

/images/scorecard/{scoreCardId}": {
      "post": {
        "tags": [
          "image-rest-controller"
        ],
        "summary": "Upload point report images",
        "operationId": "uploadPointReportImageUsingPOST",
        "consumes": [
          "multipart/form-data"
        ],
        "produces": [
          "application/json"
        ],
        "parameters": [
          {
            "name": "scoreCardId",
            "in": "path",
            "description": "scoreCardId",
            "required": true,
            "type": "integer",
            "format": "int64"
          },
          {
            "name": "file1",
            "in": "formData",
            "description": "file1",
            "required": false,
            "type": "file"
          }
        }
}

produces

uploadPointReportImageUsingPOST(params: UploadPointReportImageUsingPOSTParams): Observable<string> {
    const pathParams = {
      scoreCardId: params.scoreCardId,
    };
    const formDataParams = {
      file1: params.file1
    };
    return this.http.post<string>(`/images/scorecard/${pathParams.scoreCardId}`, formDataParams);
  }

instead it should be

uploadPointReportImageUsingPOST(params: UploadPointReportImageUsingPOSTParams): Observable<string> {
    const pathParams = {
      scoreCardId: params.scoreCardId,
    };
    const formDataParams = new FormData();
    formDataParams.set('file1', params.file1);
    return this.http.post<string>(`/images/scorecard/${pathParams.scoreCardId}`, formDataParams);
  }

I believe there shoul be a condition for this behaviour based on:

"consumes": [
          "multipart/form-data"
        ],

[abauske]

Any update on this? I really would need to upload files and so far I liked the generated ts client. Thanks for that by the way!

[jnwltr]

Thanks for feedback. You are definitely welcome to make a PR, what do you think?

[abauske]

Please have a look at the PR and mind the question in it! I'm happy to adapt anything if there is a problem with it.