search

jnz / q3vm

Q3VM - Single file (vm.c) bytecode virtual machine/interpreter for C-language input
GNU General Public License v2.0
830 stars 57 forks source link

Fix LCC/expr.c code style to avoid numerous warnings #27

Open jnz opened 5 years ago

jnz commented 5 years ago

Based on the ioquake3 pull request by WolfWings: https://github.com/ioquake/ioq3/pull/255

The mixed indentation and 'break after expression' formatting in this code makes it a bit of a landmine, and is causing a large brick of warnings with various compilers and other tools. Adding explicit bracketing and reformatting cases to make code path more explicit, as well as fixing spaces-vs-tab indentation issues due to having to re-indent this function.

codecov[bot] commented 5 years ago

Codecov Report

Merging #27 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files           2        2           
  Lines         599      599           
=======================================
  Hits          584      584           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f05c069...0046674. Read the comment docs.