search

jo / couch-daemon

High-level os daemon API for CouchDB.
14 stars 2 forks source link

Newly created db's have empty opts needed for follow #9

Closed ejeklint closed 10 years ago

jo commented 10 years ago

WOOT! the first PR on couch-daemon, thanks!

But do we really need to specify since? As I understand the Follow code, since is set to 0 per default: https://github.com/iriscouch/follow/blob/master/lib/feed.js#L54

Have you experienced issues without the since parameter?

ejeklint commented 10 years ago

You might want to test yourself (I'm a bit clumsy :-) but I had to add it to get changes feed working on newly created dbs (while daemon is running that is). The db_name/_local/daemon-name doc just didn't show up before I changed that.

jo commented 10 years ago

I thought I did but I'll try again...

jo commented 10 years ago

I now can see the problem, I will have a look at it.

jo commented 10 years ago

This was a problem with extend, Highland takes the (reverse order of arguments for extend](http://highlandjs.org/#extend).

Fixed a108317b1fcbf5e2f62a39352901335717316470

Thanks for reporting this serious bug.

ejeklint commented 10 years ago

Thanks for this quick fix! Now I can completely toss out my own badly patched version.