Fix watch option

[millette]

The watch option had a bug that took me a little while to understand.

/home/millette/marco/docza/node_modules/async/lib/async.js:862
                throw new Error("task callback must be a function");
                ^
Error: task callback must be a function

The problem was https://github.com/jo/couchdb-push/blob/master/index.js#L169

 .on('all', queue.push)

queue.push expects its second argument to be a callback according to https://github.com/caolan/async/tree/v1.5.2#queueworker-concurrency but chokidar.on('all', cb) sends three arguments, none of which is a callback.

[jo]

Awesome, thanks!

[millette]

Let me know if you're looking for a co-mainainer for your couchdb-bootstrap (and related) projects.

[jo]

Hi @millette, thank you so much for your offer to help me maintaining the couchdb-bootstrap suite. Your help is very much appreciated! I'll add you to the repos.

I'm using Semantic Release to automatically publish npm releases from commits. So for this pull, please squash your commits into a single commit, following the AngularJS Git Commit Message Conventions. Than, once merged to master, Semantic Release will publish 2.3.2 from the Travis run.

Maybe we can have a chat about my future plans for the couchdb-bootstrap suite?

\o/ Johannes

[millette]

It's great to be able to give a hand.

I just squashed/merged from the github interface (never squashed before). Not sure how much of this is automated (I'm familiar with semver, but never used Semantic Release before), I haven't tagged anything. Guess I'll see what happens in the next few minutes.

I'm millette on freenode, hanging in a few couchdb/pouchdb channels. Talk to you soon.

[jo]

:+1:

https://travis-ci.org/jo/couchdb-push/jobs/177595406#L350 shows a problem here, preventing the release. I guess its because of the capitalized "Fix". Should be "fix: watch option" instead. You can just issue another (empty) commit on master to retrigger the release build:

git commit --allow-empty -m "fix: watch option"

[millette]

Doh, I looked twice at the angular docs and your commit history. Still got it wrong on the first character ;-) Sorry about that.

[jo]

np at all :)

[jo]

Here we go: https://github.com/jo/couchdb-push/releases/tag/v2.3.2