jo1gi / audiobook-dl

Audiobook CLI downloader
GNU General Public License v3.0
248 stars 43 forks source link

fetching metadata #4

Closed evafans closed 1 year ago

evafans commented 3 years ago

Will the audio from scribd containing metadata(author,narrator),if it does, what is the error that I can't get it? File "C:\Program Files\Python39\Scripts\audiobook-dl-script.py", line 33, in sys.exit(load_entry_point('audiobook-dl==0.1.0', 'console_scripts', 'audiobook-dl')()) File "C:\Program Files\Python39\lib\site-packages\audiobook_dl-0.1.0-py3.9.egg\audiobookdl__main__.py", line 42, in run File "C:\Program Files\Python39\lib\site-packages\audiobook_dl-0.1.0-py3.9.egg\audiobookdl\utils\service.py", line 138, in download File "C:\Program Files\Python39\lib\site-packages\audiobook_dl-0.1.0-py3.9.egg\audiobookdl\utils\metadata.py", line 30, in add_metadata File "C:\Program Files\Python39\lib\site-packages\audiobook_dl-0.1.0-py3.9.egg\audiobookdl\utils\metadata.py", line 20, in add_id3_metadata AttributeError: 'NoneType' object has no attribute 'items'

evafans commented 3 years ago

Also,it wont download covers.

evafans commented 3 years ago

I tried to reinstall it,now I cant download files,dnw.

C:\Users\Administrator>audiobook-dl -c C:\audiobook-dl-master\cookies.txt https://www.scribd.com/listen/237959141 Traceback (most recent call last): File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\Scripts\audiobook-dl-script.py", line 33, in sys.exit(load_entry_point('audiobook-dl==0.1.0', 'console_scripts', 'audiobook-dl')()) File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\Scripts\audiobook-dl-script.py", line 25, in importlib_load_entry_point return next(matches).load() File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\importlib\metadata.py", line 77, in load module = import_module(match.group('module')) File "C:\Users\Administrator\AppData\Local\Programs\Python\Python39\lib\importlib__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "", line 1030, in _gcd_import File "", line 1007, in _find_and_load File "", line 972, in _find_and_load_unlocked File "", line 228, in _call_with_frames_removed File "", line 1030, in _gcd_import File "", line 1007, in _find_and_load File "", line 984, in _find_and_load_unlocked ModuleNotFoundError: No module named 'audiobookdl'

jo1gi commented 3 years ago

I think I have fixed the bug with metadata, but it still does not download the books. Covers are currently not supported with Scribd.

evafans commented 3 years ago

the updated version has covers now,but the audio only contains chapter number,without author and narrotor,is it unusual,or it is the way it is?

jo1gi commented 3 years ago

It's the way it is. I haven't implemented author and narrator for Scribd yet.

evafans commented 3 years ago

I think this function can be achieved, there is a isbn number to every audiobook ,using isbn you can get detailed info and cover from audible.

thedkm commented 2 years ago

It's the way it is. I haven't implemented author and narrator for Scribd yet.

author is there now , Just need to Add title and album , well title==album , so getting title and adding it to file , can u add it?

jo1gi commented 2 years ago

I have added support for title now. I have only put it in the title tag and not the album tag, because I want the album tag to be the series if that's available. What do you think?

thedkm commented 2 years ago

ahh thats fine , title was must now I don't have to manually add it on each file.

Album : Forty is Fabulous #04 Track name : Making Midlife Marvels Performer : Heloise Hull Original/Lyricist : Heloise Hull

nice work BTW i noticed that now ffmpeg merge doesn't show any progress thats bad , can u enable it again?

thedkm commented 2 years ago

NotADirectoryError: [WinError 267] The directory name is invalid: 'The Devil\u0026#39;s Choir: A Victor Lessard Thriller'

error on this scribd orignals https://www.scribd.com/audiobook/542379701/The-Devil-s-Choir-A-Victor-Lessard-Thriller

jo1gi commented 2 years ago

I think I have fixed the problem, but I'm not sure. I don't run windows and it's a windows specific problem.

thedkm commented 2 years ago

I think I have fixed the problem, but I'm not sure. I don't run windows and it's a windows specific problem.

Ohh ok will test it , BTW did able to merge aac files yet?

thedkm commented 2 years ago

i noticed that now ffmpeg merge doesn't show any progress thats bad , can u enable it again? what about this??

jo1gi commented 2 years ago

i noticed that now ffmpeg merge doesn't show any progress thats bad , can u enable it again? what about this??

I can make it an option.

BTW did able to merge aac files yet?

Not yet. I don't know whats wrong. Will try to figure it out.

thedkm commented 2 years ago

make that option for verbose ffmpeg output .

about aac files i tried to convert all of aac files into m4b files using ffmpeg script then tried to merge these m4bs into single m4b it worked but it takes twice as long sadly.

jo1gi commented 2 years ago

I have created an new option, --verbose-ffmpeg 2ea824b.

thedkm commented 2 years ago

I have created an new option, --verbose-ffmpeg 2ea824b.

Thanks