joBr99 / nspanel-lovelace-ui

Custom Firmware for NsPanel with the design of HomeAssistant's lovelace UI in mind, works with Tasmota.
GNU General Public License v3.0
856 stars 187 forks source link

Turn App to ADBase APP #1181

Closed Odianosen25 closed 4 months ago

Odianosen25 commented 4 months ago

This PR converts the app into an AD base app instead of HASS app. This has the following benefits:

joBr99 commented 4 months ago

hey, why did you close the PR?

Odianosen25 commented 4 months ago

Hello @joBr99,

Apologies abt that, as I noticed I made the PR against the main branch instead of the dev one. Will aim to create it again, but against the dev this time.

kind regards

joBr99 commented 4 months ago

sounds strange, but please do it against the main branch - I've added the dev branch to separate documentation between dev and the latest release, but currently main is still used as development

I started to write a standalone addon that isn't based on appdaemon (https://github.com/joBr99/nspanel-lovelace-ui/tree/main/nspanel-lovelace-ui) to get around of the limitations of appdaemon that are mainly related to the fact that appdaemon is currently using the rest api of homeassistant instead of the websocket api, but I might reverse on this, as it looks like they are working on it.

Odianosen25 commented 4 months ago

Ah ok I will reopen it then.

I am one of the core devs on AD, actually I built the MQTT plugin being used in AD.

We will work to push this development asap, so you won’t need to bother abt it.

kind regards

joBr99 commented 4 months ago

lol, much appreciated - didn't notice that you are one of the appdaemon devs :)

if you don't mind I'm going to reach out to you on discord

Odianosen25 commented 4 months ago

Yeah sure