Add webkit-web-view-evaluate-javascript-from-gresource.

[aartaka]

This adds webkit-web-view-evaluate-javascript-from-gresource -- a convenience function akin to webkit-web-view-evaluate-javascript, yet with loading from gresource.

Applications

• I've started implementing readability-mode for Nyxt similar to Reader View of Epiphany. They use gresource to load third party library (namely Mozilla's Readability.js). That's for a reason -- plain JavaScript evaluation errors out because of complex object interrelation in the library. So, to implement readability-mode, I need to have JavaScript evaluation from gresource
• This can also be used to implement ffi-buffer-load-javascript-from-file -- a general-purpose library-loading function that can be useful (e.g. https://github.com/atlas-engineer/nyxt/issues/213), especially for third-party extensions. Draft implementation is:

  (defmethod ffi-buffer-load-javascript-from-file ((buffer gtk-buffer) pathname)
  (let ((xml-pathname (merge-pathnames (pathname (str:concat (pathname-name pathname) ".gresource.xml"))
                                     (uiop:pathname-directory-pathname pathname)))
      (xml `(:gresources
             (:gresource :prefix ,(uiop:pathname-directory-pathname pathname)
                         (:file :compressed "true" (str:concat ,(pathname-name pathname)
                                                               "."
                                                               ,(pathname-type pathname)))))))
  (with-open-file (file xml-pathname
                        :direction :output
                        :if-does-not-exist :create
                        :if-exists :supersede)
    (princ (eval `(markup:xml ,xml)) file)
    (webkit:webkit-web-view-evaluate-javascript-from-gresource
     (gtk-object buffer)
     (uiop:native-namestring pathname)))))

  And most of the code is XML generation for gresource xD

Caveats

• webkit-web-view-run-javascript-finish is used to get results of evaluation from gresource. Epiphany people do that, so it shouldn't be dangerous. However, using webkit-web-view-run-javascript-from-gresource-finish can be cleaner and more consistent. Is it worth duplicating javascript-evaluation-complete callback with just one line altered?

How Has This Been Tested

• cl-webkit compiles with no warnings on this patch.
• This patch relies on battle-tested building blocks like javascript-evaluation-complete, so it shouldn't break terribly.

EDIT: Battle-tested.

[Ambrevar]

(merge-pathnames (pathname (str:concat (pathname-name pathname) ".gresource.xml"))
                                       (uiop:pathname-directory-pathname pathname))

Why not just

(pathname (str:concat (namestring pathname) ".gresource.xml"))

?

[Ambrevar]

This

(str:concat ,(pathname-name pathname)
                                                                 "."
                                                                 ,(pathname-type pathname))

yields the wrong thing when the pathname does not have an extension.

Flet this instead:

(defun file-basename (file)
  "Return the file basename (including the extension)."
  (apply #'str:concat (pathname-name file)
         (sera:and-let* ((ext (file-extension file)))
           `("." ,ext))))

[Ambrevar]

uiop:native-namestring errors out on wildcards. Use uiop:parse-native-namestring instead.

[Ambrevar]

Thank you for this feature! Please fix the docstring and I'll merge :)

[aartaka]

Done. Docstring of webkit-web-view-evaluate-javascript is fixed too (is upcase JAVASCRIPT okay if it's argument name?)

[Ambrevar]

Thanks!