search

joachifm / cl-webkit

A binding to WebKitGTK+ for Common Lisp
MIT License
52 stars 15 forks source link

webkit2.init.lisp: Add micro webkit version to *features*. #71

Closed aadcg closed 1 year ago

aartaka commented 1 year ago

CC @joachifm, can you give @aadcg commit access? He's likely to work on cl-webkit from time to time.

joachifm commented 1 year ago

CC @joachifm, can you give @aadcg commit access? He's likely to work on cl-webkit from time to time.

Sure. Invite sent.

aadcg commented 1 year ago

@Ambrevar OK to merge?

Question: This PR introduces a change. WEBKIT2 used to be member of *features*, but it is now replaced with WEBKIT-2. Should we tag a new release? Thanks.

aartaka commented 1 year ago

Question: This PR introduces a change. WEBKIT2 used to be member of *features*, but it is now replaced with WEBKIT-2. Should we tag a new release? Thanks.

I'd add this back hard-coded until we hit WebKit 3 :)

aadcg commented 1 year ago

@aartaka Ok to merge?

aartaka commented 1 year ago

OK to merge!

aartaka commented 1 year ago

Merged as b8ae1e2e379a297860e21beae801c91c790d5408 (how do we actually merge a singular commit? cherry-pick-donating it to master?)

aadcg commented 1 year ago

Thanks for merging! .

how do we actually merge a singular commit? cherry-pick-donating it to master?

In this case, when the contribution is coming from a fork, I usually "merge" it locally and then push to master. Since this is a simple merge, cherry picking is a good strategy. In short, similarly to the way you did I believe.

aartaka commented 1 year ago

Cool ^_^

Ambrevar commented 1 year ago

Thanks!