joakimkarlsson / igloo

A framework for unit testing in C++
Boost Software License 1.0
153 stars 32 forks source link

Ints in TestResults and TestRunner? #13

Closed dougbarlow closed 2 years ago

dougbarlow commented 10 years ago

Hi. I am using XCode on a 64-bit Mac with Igloo. It is great. Thank you!

One thing: I am seeing warnings that I lose precision (unsigned long to int) in testrunner.h and testresults.h. The warnings occur in the methods that use std::list<>.size(). I can give specific lines if you would like or submit a pull request.

If I change the int return value for std::size_t, it all compiles great. Should we use std::size_t instead of int? Then it should compile without warnings on both 32-bit and 64-bit OSes.

-Doug

joakimkarlsson commented 10 years ago

Hi.

Sounds like something we should fix.

If you could submit a PR that would be awesome!

Thanks

/Joakim

On Mar 6, 2014, at 6:05, dougbarlow notifications@github.com wrote:

Hi. I am using XCode on a 64-bit Mac with Igloo. It is great. Thank you!

One thing I am seeing are warnings that I lose precision (unsigned long to int) in testrunner.h and testresults.h. The warnings occur in the methods that use std::list<>.size(). I can give specific lines if you would like or submit a pull request.

If I change the int return value for std::size_t, it all compiles great. Should we use std::size_t instead of int? Then it should compile without warnings on both 32-bit and 64-bit OSes.

-Doug

Reply to this email directly or view it on GitHubhttps://github.com/joakimkarlsson/igloo/issues/13 .