Closed bcachet closed 12 years ago
I refactor xmlwritter and write tests for this module.
I think you can review this pull request and discuss about it.
Have a nice day
Bertrand
Great. I'll take a look at it after the weekend.
/Joakim
On Fri, Aug 24, 2012 at 1:19 PM, Bertrand Cachet notifications@github.comwrote:
I refactor xmlwritter and write tests for this module.
I think you can review this pull request and discuss about it.
Have a nice day
Bertrand
—
Reply to this email directly or view it on GitHubhttps://github.com/joakimkarlsson/igloo/pull/2#issuecomment-7998684.
Looks good. Some comments inline in commit 36c9234.
Could you rename xmlwritter.h -> xmlwriter.h as well?
/Joakim
Modifications have been performed. Thanks a lot for the comments. Didn't know that variable starting with underscores are considered reserved by C++ standard. Sorry for the writer with tt. Typo.
Bertrand
Add XUnitResultsOutput class generate XML stream compliant with XUnit
Refactor ResultsOutput constructor to take output stream in parameter => we can output generated stream to a file.
SuccessedTestResult and FailedTestResult have not been modified
I hope this new version will be OK
Have a nice day
Bertrand