joakimskoog / AnApiOfIceAndFire

An API of Ice And Fire is the world's greatest source for quantified and structured data from the universe of Ice and Fire (as well as the HBO series Game of Thrones).
Other
352 stars 71 forks source link

Add character image #119

Closed RNOVOSELOV closed 7 years ago

RNOVOSELOV commented 7 years ago

Add field wuth URL to the character's image or of the actor photo to the "character"-response

iamtekeste commented 7 years ago

This is really a great idea. But I don't think it is easy thing to do. @joakimskoog Do you have any guidance or idea on how to do this? I would love to help.

joakimskoog commented 7 years ago

This is a great suggestion that has been up for discussion earlier. I'll reiterate my concerns and thoughts regarding this feature down below:

Before we start implementing this feature we need to answer the questions above.

RNOVOSELOV commented 7 years ago

1) According to copirates:

Answers from designers:

2) Host our own images or link to someone else's I think it's more your question @joakimskoog, as the creator and architect of this API. Store your images of course more reliable. Byt In my opinion, it's enough to give a link to the pictures on http: //awoiaf.westeros.org. I, like the android developer, will just correctly process the broken links and substitute the default picture in case the image is missing from the link. I do not think there will be a lot of traffic and their bandwidth should be enough. At least I will download pictures as they are viewed by the user and not all at once.

joakimskoog commented 7 years ago

I'm merging all discussions about images in this issue: https://github.com/joakimskoog/AnApiOfIceAndFire/issues/127