joaktree / J5

Joaktree migration to Joomla 5
GNU General Public License v3.0
2 stars 0 forks source link

Geocode button results in a bad URL #3

Open felixkat opened 5 days ago

felixkat commented 5 days ago

image

Geocode button results in a bad URL.

image

It does this with either map service.

conseilgouz commented 4 days ago

Hi,

Please give a copy of Joaktree configuration, Maps Services tab.

Is "geocode by subdivision" parameter set to yes or no ? try to set it to no.

geocode

Pascal

conseilgouz commented 4 days ago

Hi, It's related to GoogleMap geocoding and not OpenStreeMap.

It has been fixed by version 2.0.3-rc3 : https://github.com/joaktree/J5/releases/download/2.0.3-rc3/J5-2.0.3-rc3.zip

Note: I still have doubts about the use of "Geocode the subdivision" parameter. I don't use GoogleMap, so, I'm not sure about this.

Pascal

felixkat commented 4 days ago

Hi,

After some testing, it appears the main issue occurs if you set interactive map to 'no'.

The error message will vary depending if you have details in the country and language code. The original screenshot I sent you didn't have country or language code entered.

The following settings:-

image

Produce the following error.

image

fontanil commented 4 days ago

Sorry! With rc3, subdivision activated or not, I can't geocode with Google nor OpenStreetMap. If I disable geocoding, I get errors on sources that I didn't have at the time.

Robert

fontanil commented 4 days ago

No error with RC2 version (Google no subdivision).

felixkat commented 4 days ago

This was tested with RC3 as pictured with geocode set to no.

The error only appears if items haven't been processed, so I performed UPDATE #___joaktree_locations SET "indServerProcessed"="0" for testing.

I will test again later.

conseilgouz commented 4 days ago

Hi,

I disabled indServerProcessed variable in https://github.com/joaktree/J5/releases/download/2.0.3-rc4/J5-2.0.3-rc4.zip

@fontanil : It seems that it does not work anymore and I still do not understand how it's usefull anyway.

Geocoding with OpenStreetMap is now correct and GoogleMap should be OK too.

Pascal

felixkat commented 4 days ago

I thought it was there so only locations that haven't been geocoded were processed. so gecoding can be done in smaller batches without starting from the beginning.

So if all records are set to indServerProcessed"="1" then geocding isn't performed.

I could be wrong though, I'm still learning Joaktree 😄

conseilgouz commented 3 days ago

Hi, I'm not a joaktree expert, I just did Joomla 5 migration. There are a bunch of functions I did not test and some I don't see their purposes. Thank you for yor help in testing. Pascal

felixkat commented 3 days ago

I'm happy to help with the testing as I have a family members website that I'm using it to test on.