joalla / discogs_client

Continuation of the "Official Python Client for the Discogs API"
https://python3-discogs-client.readthedocs.io
Other
310 stars 50 forks source link

Add attribute artists_sort to Release class #117

Closed JOJ0 closed 2 years ago

JOJ0 commented 2 years ago

To support a feature request in beetbox/beets: https://github.com/beetbox/beets/issues/4401#top, laying out this information via the client might help.

JOJ0 commented 2 years ago

No actually it's a way to get the joined artists in a string directly from the api. have a look into the linked beets issue for an example.

JOJ0 commented 2 years ago

I misread your message @AnssiAhola, yes it definitely is an alternative to manually joining artist with the info found in join! Sorry! Yeah! :sweat_smile:

I'll open a PR soon adding join to Artist

JOJ0 commented 2 years ago

Unfortunately even though docs rendering went fine on my machine, it seams we hit an issue again: https://readthedocs.org/projects/python3-discogs-client/builds/18164644/

Will look into another time...

JOJ0 commented 2 years ago

Fixed it, was an issue in latest Sphinx version. Pinnend it to older one as documented here: https://github.com/readthedocs/sphinx_rtd_theme/issues/1343

@prcutler @AnssiAhola @alifhughes have a look into diff of this PR, this is how we can document class attributes and this is how it looks like rendered: https://python3-discogs-client.readthedocs.io/en/latest/discogs_client.html#discogs_client.models.Release.artists