search

joalla / discogs_client

Continuation of the "Official Python Client for the Discogs API"
https://python3-discogs-client.readthedocs.io
Other
299 stars 49 forks source link

[FEATURE REQUEST] Handle HTTP 429 rate limit statuses #135

Closed rmargar closed 1 year ago

rmargar commented 1 year ago

Hey,

First of all thanks for the amazing work on this library, it makes really easy to interact with the discogs API. After building a POC for an app I have in mind, I stumbled upon the problem of rate limitations by Discogs in their v2 API. I implemented a backoff mechanism in my app to overcome this, but I think it would be a great addition to implement this in the client itself, maybe by passing an attribute to the Client class so that users can control wether this is handled or not. I would also like to offer my help in order to implement this, but would like to hear your opinion on this first. Thanks!

AnssiAhola commented 1 year ago

Hey @rmargar Do you mean exponential backoff? That was implemented in version 2.3.10 and can be enabled/disabled via the Client and should be enabled by default. Which client version are you running?

Our docs for this feature

rmargar commented 1 year ago

Hi @AnssiAhola, thanks for your reply. I think the issue was that I was installing the package from the wrong pypi project (the deprecated discogs-owned one). My bad!