search

joalla / discogs_client

Continuation of the "Official Python Client for the Discogs API"
https://python3-discogs-client.readthedocs.io
Other
309 stars 50 forks source link

Promote Series information to main Release information #151

Open VinylVault opened 2 months ago

VinylVault commented 2 months ago

I know that series information is available via fetch, but it would be useful if this was available (or null) at the top level of a release

Original discussion: https://github.com/joalla/discogs_client/discussions/150

JOJ0 commented 2 months ago

This should be easy enough to implement. Similar to this one: https://github.com/joalla/discogs_client/pull/119/files but I'm not sure if Series could be ListField or rather be an ObjectField? What does the API for series return? Is it always a list of JSON objects? Or could it also be one JSON object only? Some raw API output would help to find out @VinylVault

ListField example: https://github.com/joalla/discogs_client/blob/master/discogs_client/models.py#L525

ObjectField example https://github.com/joalla/discogs_client/blob/master/discogs_client/models.py#L527

You want to draft a PR @VinylVault ? I'm happy to review and help then.

VinylVault commented 1 month ago

There is only ever on Series, that I've come across, but that isn't necessarily the case for every release ... probably best to treat is like an artist or record label (seeing as they are stored as labels and URL'd as labels [don't as me why])