joamjoamjoam / RemotePlayWhatever

GNU General Public License v3.0
14 stars 3 forks source link

Add some type info, potentially fix #4 #7

Open mbacalan opened 1 year ago

mbacalan commented 1 year ago

Wanted to do add stronger type information but I don't think friendStore and it's properties are typed anywhere. Could go further by declaring ConvertTo64BitString() on a new type but I thought that's too much into the internal of things for the purpose of this plugin.

Changed the array generation to dynamically create DropdownItem's. I'm not sure if I'm missing a special purpose there but looks like you only need an index so this should be easier to read and somewhat faster(!)

Wrapped the DropdownItem's and ButtonItem with PanelSectionRow in an attempt to fix #4 . I'm unable to test this myself though, sorry.

Let me know what you think. Cheers!