search

joan38 / kubernetes-client

A Kubernetes client for Scala
Apache License 2.0
122 stars 41 forks source link

Add a way to list and get details of a node. #234

Closed tomiwu closed 1 year ago

tomiwu commented 1 year ago

This PR is resolves #140 and essentially provides the capability to list nodes within a clause and retrieve their details.

tomiwu commented 1 year ago

Hi, @joan38. I've observed issues with the tests associated with resource deletion. Specifically, pods were lingering in the termination state for an extended duration. To address this, I have reduced the graceful period. I believe this adjustment should be suitable for testing purposes. Please share your thoughts or let me know if this solution aligns with your needs.

joan38 commented 1 year ago

Thanks @tomiwu for your contribution. That's a welcome addition. Sounds like we have some failed tests. Is it related to the shorter graceful period?

tomiwu commented 1 year ago

I experimented with those tests, and in most instances, the issue was connected to certain pods not getting removed promptly (remaining in a terminating state), causing the tests to time out. This issue wasn't caused by my changes, but I believe I've resolved it. Essentially, before running every test suite now, I ensure that Minikube has been cleaned up.

joan38 commented 1 year ago

Perfect, thanks @tomiwu!