joan38 / mill-scalafix

A Scalafix plugin for Mill build tool
MIT License
32 stars 17 forks source link

Update scalafix to 0.13.0 #202

Closed bishabosha closed 1 month ago

bishabosha commented 1 month ago

didnt test breakages

bjaglin commented 1 month ago

It looks like the bump already happened in https://github.com/joan38/mill-scalafix/pull/203

Even though 0.13.0 is backward compatible from a client perspective, before cutting a release, we could use this PR to make ExplicitResultTypes work out of the box for Scala 3 (and Scala 2.13 as a side effect).

The way this was done in sbt-scalafix was to deprecate the setting key and make its default target the full Scala version of the project. I imagine the same could be done here.

See https://github.com/scalacenter/scalafix/releases/tag/v0.13.0 for more details. Let me know if it's unclear.

lolgab commented 1 month ago

@bjaglin I applied your suggestion in #205. Do you mind reviewing it?