search

joanllenas / ngx-date-fns

⏳ date-fns pipes for Angular
163 stars 14 forks source link

is*() functions are missing #366

Closed ciriousjoker closed 2 years ago

ciriousjoker commented 2 years ago

Description of the Issue and Steps to Reproduce:

Did you search for duplicate issue? Yes

Please describe the issue and steps to reproduce, preferably with a code sample / plunker:

Some pipes are missing, which are available in date-fns.

Ensure your issue is isolated to ngx-date-fns. Issues involving third party tools will be closed unless submitted by the tool's author/maintainer.

Environment:

Browser.

Please answer the following questions:

joanllenas commented 2 years ago

Hi @CiriousJoker , thanks for your suggestion.

Cheers

joarkm1 commented 2 years ago

@joanllenas I just added the pipes in my fork. Should I create a PR?

joarkm1 commented 2 years ago

https://github.com/joarkm1/ngx-date-fns/tree/missing-is-pipes

joanllenas commented 2 years ago

Hi @joarkm1, I just started working on the three mentioned in this issue, but you went far beyond! 💯

joanllenas commented 2 years ago

Closed via https://github.com/joanllenas/ngx-date-fns/releases/tag/v8.3.0 Thanks @joarkm1! 🎉