search

joanllenas / ngx-date-fns

⏳ date-fns pipes for Angular
163 stars 14 forks source link

Missing is pipes #368

Closed joarkm1 closed 2 years ago

joarkm1 commented 2 years ago

Linked issue: #366. Note: No tests have been written. I'm unsure whether they'd be valuable since all we're doing is calling existing date-fns functions, which themselves have been tested.

joanllenas commented 2 years ago

Hey @joarkm1 , first of all, thanks a lot for this contribution! I will need some time to review all changes, but I will try to give feedback in small batches.

joarkm1 commented 2 years ago

Hey @joarkm1 , first of all, thanks a lot for this contribution! I will need some time to review all changes, but I will try to give feedback in small batches.

Happy to help! I created a shell script and used on search-and replace in my IDE otherwise it would have taken ages to create all the neccessary code 😀The pipes are quite similar so there is a lot of repetitive coding. Still some "manual" coding was required, but the scripting established a good baseline.

joanllenas commented 2 years ago

@joarkm1

I created a shell script and used on search-and replace in my IDE otherwise

That's smart! I actually handcrafted all files by hand, and yes, it took me some time :) I may steal that technique in future iterations!

joarkm1 commented 2 years ago

I think I managed to address what you noted about locale options in my latest commit.

joanllenas commented 2 years ago

@joarkm1, I will review your changes ASAP, probably tomorrow. Thanks!

joanllenas commented 2 years ago

@joarkm1 This is merged! 🎉 I will now add some tests and documentation. Then, I will create the release. Thanks for this significant contribution!