search

joanllenas / ngx-date-fns

⏳ date-fns pipes for Angular
163 stars 14 forks source link

Angular 13 : "Encourage the library authors to publish an Ivy distribution" #369

Closed marcwrobel closed 2 years ago

marcwrobel commented 2 years ago

During the build of a project, angular-cli 13 issues the following message :

⠙ Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
- ngx-date-fns [es2015/esm2015] (git+https://github.com/joanllenas/ngx-date-fns.git)
Encourage the library authors to publish an Ivy distribution.

Except this message ngx-date-fns works fine. But it seems something has to be done in the ngx-date-fns library.

marcwrobel commented 2 years ago

Seems related to https://angular.io/guide/creating-libraries#publishing-libraries.

joanllenas commented 2 years ago

Hey @marcwrobel , Nice catch 👍 I will take a look when I have some time. Thank for reporting!

MorganWaya commented 2 years ago

Hi everyone. I don't know if it is related but I obtain the following message with Angular 13:

core.mjs:1122 Uncaught Error: Type DateFnsModule does not have 'ɵmod' property.

With

    "@angular/core": "~13.1.0",
    "date-fns": "^2.28.0",
    "ngx-date-fns": "^8.3.0",

Any idea? Thank you for your work <3

marcwrobel commented 2 years ago

Hi @MorganWaya, I did not see this message after upgrading to ngx-datefns 8.3.0 / date-fns 2.28.0 / angular 13.1.1. Did you found more information about it since you posted your comment ?

MorganWaya commented 2 years ago

Hi!

It looks ok with the latest version, thank you!

jpduckwo commented 2 years ago

Keen to see this release, thanks for your efforts @joanllenas

joanllenas commented 2 years ago

Hey, I have a PR ready. Follow the instructions on the PR comment to try the beta and let me know if it works, or there are any issues. Thanks!

joanllenas commented 2 years ago

Closed via https://github.com/joanllenas/ngx-date-fns/releases/tag/v9.0.0