Add support for decoding non-const enums.

joanllenas / ts.data.json

1.7kB JSON decoding library for Typescript

BSD 3-Clause "New" or "Revised" License

205 stars 16 forks source link

Add support for decoding non-const enums. #25

Closed rhofour closed 4 years ago

rhofour commented 4 years ago

This required bumping up the target to ES2017. The syntax is a little redundant since you need the enum both as a parameter and a template parameter, but it doesn't look like there's a way to get the values of an enum at compile time from the template parameter.

joanllenas commented 4 years ago

Hi @rhofour, thanks for your contribution! The code part looks perfect, just a couple of minor things.

The target field in the tsconfig.ts file can stay as 'es5' and everything will work just fine. We need that in order to support ie11.
Could you please add a documentation section in the readme file following the format of the rest of the file?

Thanks!

rhofour commented 4 years ago

Done. I also bumped the version.

joanllenas commented 4 years ago

Thanks! the new version is ready! https://github.com/joanllenas/ts.data.json/releases/tag/v1.3.0