joanma100 / prs-plus

Automatically exported from code.google.com/p/prs-plus
0 stars 0 forks source link

[2.1] 300/?: Continue reading after book was deleted leads to crash #321

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Assign "continue reading" button to a key
2. Delete a book
3. Press on button assigned to "continue reading"

Reported here:
http://www.the-ebook.org/forum/viewtopic.php?p=875704#875704

Original issue reported on code.google.com by msukhias...@gmail.com on 12 Mar 2012 at 10:12

GoogleCodeExporter commented 8 years ago
Hi all,

I just pushed an update (rev 
http://code.google.com/p/prs-plus/source/detail?r=66426d9b0051d05da71d4a8243c105
50bcc28b76) that hopefully fixes this issue.

However, when I tried to reproduce the error on my 650 before trying to fix it, 
I couldn't.  So I have no way of knowing if this will work on the 300.  Can 
someone test this for me?

Sincerely,
Ben.

Original comment by ben.chen...@gmail.com on 13 Mar 2012 at 4:29

GoogleCodeExporter commented 8 years ago
Poke me please, if I don't comment on this for more than 3 days.

Original comment by msukhias...@gmail.com on 13 Mar 2012 at 4:30

GoogleCodeExporter commented 8 years ago
kbook.model.onEnterContinue already checks for currentBook, so adding it to the 
action isn't necessary. Not sure why currentBook would still exist when 
executing though, deleting the book should clear it (which is probably why Ben 
couldn't reproduce the problem). Perhaps it matters which method is used to 
delete the book?

Original comment by quisvir on 13 Mar 2012 at 4:42