joannalew / yelp-clone

Clone of the website, Yelp, where users can leave reviews for businesses.

http://burp2.herokuapp.com

1 stars 0 forks source link

PA Review: User Authentication #2

Closed joannalew closed 5 years ago

joannalew commented 5 years ago

User Auth

Functionality

[x] The main button with logo should link to /
[x] Has working demo login

Before Login

[x] The /login page should not display a link to Log In. Same for /signup
[x] Errors should display for both /signup and /login.
[x] Errors should clear when moving between /signup and /login.
[x] Can sign up a user
[x] Can sign in as a user
[x] Can log out a user
[x] Can't sign up with the same username/email
[x] Pressing enter after filling out the session form should use the form data, not the demo user

After Login

[x] Should not be able to visit /login or /signup
[x] Should be able to refresh the page and still be logged in

Style

[x] The site should look exactly like the actual site
[x] All relevant elements should have cursor: pointer on hover
[x] When errors are displayed, most elements should not move around the page (particularly input boxes)
[ ] Remove Redux logger and all console.log()'s from production

evhumphrey commented 5 years ago

Feedback

Love the cat pic!

Make sure to remove console.logs and redux logs before next friday.

Navbar

[ ] I would style your navbar a tags so that that the click area is bigger.