search

joanpablo / reactive_forms

This is a model-driven approach to handling form inputs and validations, heavily inspired in Angular's Reactive Forms
MIT License
471 stars 90 forks source link

ReactiveTextField does not set a default brightness #434

Closed chillbrodev closed 10 months ago

chillbrodev commented 10 months ago

While it is nice that the ReactiveTextField supports overriding the keyboardAppearance, the default should not be null and instead match the theme's primaryBrightness.

Having the default be null, leads to needing to set the keyboardAppearance manually to MediaQuery.platformBrightnessOf(this). The ReactiveTextField should utilize this value by default while still providing the ability to accept an override.

joanpablo commented 10 months ago

Hi @chillbrodev,

Thanks for the feedback. I will take a look at this property.

joanpablo commented 10 months ago

Hi @chillbrodev,

I have checked the native TextFormField widget from Flutter Team, and they don't provide a default keyboardAppearance. The ReactiveTextField tries to mimic the same experience that anyone can have with native widgets, and add the extra layer of reactivity. Maybe this is something you can suggest to the Flutter Team.

Thanks again for using Reactive Form, and for your feedback.

chillbrodev commented 10 months ago

Hi @chillbrodev,

I have checked the native TextFormField widget from Flutter Team, and they don't provide a default keyboardAppearance. The ReactiveTextField tries to mimic the same experience that anyone can have with native widgets, and add the extra layer of reactivity. Maybe this is something you can suggest to the Flutter Team.

Thanks again for using Reactive Form, and for your feedback.

Hey @joanpablo,

That sounds good, I can raise the feedback with the Flutter Team. I'll go ahead and close this.

Thanks for building Reactive Form, my team loves it and we use it on all our projects.