search

joansola / slamtb

SLAM Toolbox
GNU General Public License v3.0
258 stars 121 forks source link

Add covariance matrix computation + ellipse drawing for graphSLAM. #1

Closed marija-p closed 5 years ago

marija-p commented 5 years ago

Hey @joansola , here's my PR. I tested it and it seems to work for me with the standard example. Please let me know if I should make any changes. Many thanks for the opportunity to contribute! :smile: Masha

joansola commented 5 years ago

OK Merged! You are now in the credits, congratulations!!

Joan

On 16 Oct 2018, at 18:46, Marija Popovic notifications@github.com wrote:

@marija-p https://github.com/marija-p requested your review on: #1 https://github.com/joansola/slamtb/pull/1 Add covariance matrix computation + ellipse drawing for graphSLAM..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/joansola/slamtb/pull/1#event-1907509742, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlveFlIdL8ztfTvHFxpHK2hHKgKqwNks5ulhtZgaJpZM4XfMfH.

marija-p commented 5 years ago

@joansola Thanks a lot! :+1: Could you please change my name to "Marija"? :smile: Not "Marjia"?

joansola commented 5 years ago

Oh !! Of course, and sorry!

J

On 17 Oct 2018, at 09:37, Marija Popovic notifications@github.com wrote:

@joansola https://github.com/joansola Thanks a lot! 👍 Could you please change my name to "Marija"? 😄 Not "Marjia"?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joansola/slamtb/pull/1#issuecomment-430540504, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlvVkTmStEUfF-51Y4w6GgjRR-rxHyks5uluxhgaJpZM4XfMfH.

marija-p commented 5 years ago

@joansola Thanks :)