search

joaogarin / angular-electron

Angular2 and Electron starter using webpack
150 stars 53 forks source link

Issue with Material Tabs: must include BrowserAnimationsModule #68

Closed briosheje closed 7 years ago

briosheje commented 7 years ago

Since some updates angular 2 material started using the BrowserAnimationsModule which must be included in order to use the Angular 2 material tabs (https://material.angular.io/components/component/tabs).

This needs to be added in the app.ts file import { BrowserAnimationsModule } from '@angular/platform-browser/animations';

And injected in the @NgModule


@NgModule({
    imports: [
        BrowserModule,
        FormsModule,
        ReactiveFormsModule,
        HttpModule,
        BrowserAnimationsModule, // <--- here

Else an error will pop up and will prevent the execution of the next scripts :) (and tabs won't work)

joaogarin commented 7 years ago

Fixed in https://github.com/joaogarin/angular-electron/commit/6bbcd1d5b21a7d0905a9fd64042c8dcf9f4c7985

joaogarin commented 7 years ago

Thanks!;) :tada:

briosheje commented 7 years ago

@joaogarin Thank you for the beautiful starter, I'm using it a lot. Just a side question: are you having problem with karma aswell? I had to do several changes to the webpack.test.js and the karma config file to make it work, it usually throws me several errors whenever I try to test anything which has some electron-module included.