search

joaojeronimo / node_redis_cluster

A thin wrapper over node_redis to make it work with Redis Cluster
53 stars 17 forks source link

old node-redis inside node_redis_cluster #22

Open lucasrochaa opened 8 years ago

lucasrochaa commented 8 years ago

Hi Joao, first, congratulations with the cluster lib, everything for my app is working after refactor, but i notice the version of the redis inside node_redis_cluster is too old 0.8.x and today we are @ 2.2.3 with a lot of enhancements & commands.

Are u thinking in repacking the node_redis_cluster with the latest node_redis?

If not could u show me the way?

tanx!

joaojeronimo commented 8 years ago

Hi, thanks!

Well that is a bit tricky. When I wrote this 3 (4 ?) years ago I was a completely different developer than I am today and ended up not writing tests for this, which means we have no baseline to run against and see if everything is ok if we were to make this change or any other.

This seems like a pretty significant change, because it's raising two major versions of node-redis, and with that we are bound to run into a couple of breaking changes. Because this has no tests, we cannot find them in advance before someone runs into them when using the module, which is very unpleasant.

I cannot devote any time to this project as of now, so if you want to do this I would suggest adding basic tests, bumping the dependency's version and then checking if everything is still alright.