Can I change spaces to tabs?

joaojeronimo / node_redis_cluster

A thin wrapper over node_redis to make it work with Redis Cluster

53 stars 17 forks source link

Can I change spaces to tabs? #7

Closed h0x91b closed 9 years ago

h0x91b commented 9 years ago

In all our projects we use tabs, can I change this project too? (this is BIG commit :) )

joaojeronimo commented 9 years ago

I'm not very fond of that idea since two spaces is most popular among node people for indentation, in fact it's in (Felix's Style Guide)[https://github.com/felixge/node-style-guide], but if you feel it actually makes a difference for the better then go for it

tleef commented 9 years ago

For what its worth, I'm fairly opposed to tabs particularly in project that are on Github because they use a tab-size of 8. I am in favor of a .editorconfig however :)

There is a long standing issue open about this here: https://github.com/isaacs/github/issues/170

example: https://github.com/tleef/tab-test/blob/master/index.js