search

joaoleal / CppADCodeGen

Source Code Generation for Automatic Differentiation using Operator Overloading
Other
162 stars 36 forks source link

Remove CMake warnings #69

Closed nim65s closed 2 years ago

nim65s commented 2 years ago

Hi,

This PR removes a few configuration warnings.

The first commit fix:

CMake Deprecation Warning at CMakeLists.txt:18 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

and:

CMake Warning (dev) at test/CMakeLists.txt:153 (ADD_EXECUTABLE):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    /tmp/CppADCodeGen/test/cppad/cg/model/threadpool/pthreadpool_raw.cpp
Call Stack (most recent call first):
  test/cppad/cg/model/threadpool/CMakeLists.txt:22 (add_cppadcg_test)
This warning is for project developers.  Use -Wno-dev to suppress it.

And the second commit fix:

CMake Warning (dev) at /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (CLANG) does
  not match the name of the calling package (Clang).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindClang.cmake:64 (find_package_handle_standard_args)
  CMakeLists.txt:53 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

and:

CMake Warning (dev) at /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (VALGRIND)
  does not match the name of the calling package (Valgrind).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindValgrind.cmake:27 (find_package_handle_standard_args)
  test/CMakeLists.txt:211 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

The second one is just a bunch of find and replace, that could be made the other way if you prefer.

joaoleal commented 2 years ago

Hello Guilhem,

I've tested these changes on my system and they look good. Thank you for your contribution.