joaomgcd / JoinDesktop

A desktop app for Join built in Electron
240 stars 20 forks source link

Hotkeys not working #23

Closed skarfie123 closed 3 years ago

skarfie123 commented 3 years ago

Only "Show App" hotkey is working. the three media hotkeys and any custom ones I add to device actions also don't work.

I am able to set the hotkey fine, just nothing happens when I try to use it.

I have tried simpler hotkeys too, in case these were too complex, but still no luck.

image

joaomgcd commented 3 years ago

Thanks for the report. I cannot reproduce...

Does the "Repeat Last Command" one also not work? Could you try with something like Shift + Control + L please?

skarfie123 commented 3 years ago

Just tried Shift + Control + L with "Repeat Last Command". Able to set it, but nothing happens when I press it.

joaomgcd commented 3 years ago

Thanks. What OS are you on?

skarfie123 commented 3 years ago

Windows 10 Version 20H2 Build 19042.928

joaomgcd commented 3 years ago

Thanks. Exactly the same as me so it can't be that. If you set shortcut you used for the Show App action on a different action, does that work? I'm thinking that some other app may be blocking these?

skarfie123 commented 3 years ago

Let ASC = Alt+Shift+Control Ok, I Tried ASC + F1 And it worked for all cases. Then I tried F2, F3 and they also worked. However, as soon as I set one of them to ASC+Digit8 or ASC+Numpad8, they don't work but they also make the F one not work.

Minimal example: Before: Skip Song = ASC + F3 (Working) After: Skip Song = ASC + F3 (Not Working) Show App = ASC + Digit8 (Not Working)

Much more complex than I expected...

joaomgcd commented 3 years ago

So, just so I understand, if all your shortcuts are just based on Ctrl+Shift for example, it all works?

skarfie123 commented 3 years ago

It doesn't matter if its Alt+Ctrl+Shift or Ctrl+Shift. Simply introducing a hotkey with Digit or Numpad, breaks any previously working ones with F Eg. If I only use F ones, it works. eg ASC+F1 and ASC+F2 both work If I introduce a digit or Numpad one, neither ASC+F1 nor ASC+Digit1 work (ie the F1 hotkey stops working because of Digit1)

joaomgcd commented 3 years ago

Ok, fixed on this commit! :) Thank you!