search

joaomgcd / JoinDesktop

A desktop app for Join built in Electron
238 stars 19 forks source link

Bugged send file function #47

Open mat4444 opened 2 years ago

mat4444 commented 2 years ago

Hello, The "send files to your device" function does not work as expected when the receiving device is on another network. Join desktop tries to upload the files to Google Drive forever, but the file is never received. Here are the errors on the console:

command.js:619 Error: No file Id to share
    at Function.errorPromise (util.js:324)
    at getShareUrlAndData (googledrive.js:200)
    at async Promise.all (/C:/Users/home/AppData/Local/com/app-1.1.2/resources/app.asar/index 0)
    at async DeviceAndroidPhone.uploadFilesGoogleDrive (device.js:209)
    at async Devices.uploadFiles (device.js:166)
    at async DeviceAndroidPhone.uploadFiles (device.js:223)
    at async CommandUploadFiles.customizePush (command.js:614)
    at async CommandUploadFiles.executeSpecific (command.js:123)
    at async HTMLDivElement.commandRender.onclick (controlcommand.js:54)

This issue does not exist when both devices are on the same network.

Additionally, drag'n'drop works to send a local file works fine, even when the two devices are on different networks. The issue is only when using the function on the device list page.

joaomgcd commented 2 years ago

Hi. Sorry for the delay. Does it work with the latest version? Does it work if you drag and drop a file on to the device instead?