Join API URL structure is incorrect for Clipboard

joaomgcd / JoinDesktop

A desktop app for Join built in Electron

238 stars 19 forks source link

Join API URL structure is incorrect for Clipboard #53

Closed richaardvark closed 2 years ago

richaardvark commented 2 years ago

When creating a Join API URL to set a device's clipboard the generated parameter is incorrectly coded and generates "&urlclipboard=" instead of "&clipboard=" which then results in an error when the URL is loaded.

This typo is of course not in this electron web app itself but is in the general Join Web website and affects all platforms that use the web interface.

joaomgcd commented 2 years ago

Thank you! Fixed! :)

richaardvark commented 2 years ago

Thank you! Fixed! :)

Hey João (sorry if I'm not supposed to comment on a closed issue)... it does seem to be fixed on the "Join Web" website interface, but I have tried both the .deb and appimage versions of the Linux Join Desktop app and they are still making making the wrong URL string for the clipboard parameter/are still making "&urlclipboard=" instead of "&clipboard=".

joaomgcd commented 2 years ago

Yeah, sorry about that, I need to put new builds out for the various versions to fix on those as well, sorry!