search

joaomgcd / JoinDesktop

A desktop app for Join built in Electron
238 stars 19 forks source link

M1 Native #57

Open electr1fy0 opened 2 years ago

electr1fy0 commented 2 years ago

Please make the mac app run natively on Apple Silicon Macs as having the intel app is basically unnecessary resource consumption.

ameeno commented 2 years ago

I want this too. can we just build it for m1 target?

tommyent commented 2 years ago

This app is not native. Also as far as I know it still requires another electron app for M1. I's been a while since they release 11.0 but there were dependency issue back then as well.

Just curious but does anyone have any numbers on electron running on intel vs M1? Is it any better?

ameeno commented 2 years ago

VScode and other apps that use electron do work on m1 native for electron version 11 I think.

I have not tried to build this app with a newer electron for arm64.

ChronoStriker1 commented 2 years ago

Rebuilding with electron 18.2 (only did that as it was the most up-to-date that I could download), seems to work and the app that is created is running as an apple silicon app.

electr1fy0 commented 2 years ago

@ChronoStriker1 Can you share that build?

ChronoStriker1 commented 2 years ago

I forked it and released it on my GitHub. Whenever @joaomgcd has a new build, this won't be needed.

electr1fy0 commented 1 year ago

Doesn't launch @ChronoStriker1

ChronoStriker1 commented 1 year ago

I'm currently using the build that I uploaded and its running on my MacBook M1 Pro, can't really help further.