Changed menu entry files and classes in variables

joaomgcd / JoinDesktop

A desktop app for Join built in Electron

240 stars 20 forks source link

Changed menu entry files and classes in variables #6

Closed rakeshdas1 closed 4 years ago

rakeshdas1 commented 4 years ago

Made file names and class names in the menu entries variables, will easier to refactor in the future.

joaomgcd commented 4 years ago

Thanks for the pull request! I don't think there's any advantage doing this though, seeing that those strings will only ever be used in one place. No point in creating a separate function for each one :) thanks for the effort but I'll pass on this one. Thanks all the same!