search

joaomgcd / JoinDesktop

A desktop app for Join built in Electron
240 stars 20 forks source link

SMS issues #8

Open tommyent opened 4 years ago

tommyent commented 4 years ago

Haven't tried to look at things but I had this from the other day and is still an issue Trace: TypeError: Cannot read property 'address' of undefined at ControlSMSConversation.renderCurrentSmsConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/conversation/controlsmsconveration.js:125:89) at async ControlSMSConversation.setSmsConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/conversation/controlsmsconveration.js:89:9) at async AppHelperSMS.reloadConversationFromNetwork (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:153:9) at async AppHelperSMS.switchToConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:148:9) at async AppHelperSMS.setMode (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:77:13)

Also Screen Shot 2020-07-28 at 1 55 09 PM should be Screen Shot 2020-07-28 at 1 56 03 PM

Not sure if this has anything to do with RCS

joaomgcd commented 4 years ago

Thanks! Probably an issue with MMS. Haven't had a chance to test those yet (my network makes it hard and expensive to use those).

Do you get that error every time an MMS is in the conversation?

tommyent commented 4 years ago

The undefined address happens with or without MMS the [Urgent!] MESSAGE_SUBJECT is every MMS

joaomgcd commented 4 years ago

Ok, think this is fixed. Can you please check?

tommyent commented 4 years ago

Images are still missing. There is now no indication of an image at all. Screen Shot 2020-07-30 at 12 46 22 PM

joaomgcd commented 4 years ago

Yeah, unfortunately I wasn't able to test images yet solely because I have no way to get MMS on my phone right now :/ Need to find a way to do that soon...

tommyent commented 4 years ago

What's the issue with getting MMS on your phone? Is it a service provider issue?

joaomgcd commented 4 years ago

Yeah, MMS aren't really used here so I don't even have a way of sending them to myself :/

tommyent commented 4 years ago

Well the best I can do is offer to test commits. I thought there were test SMS/MMS gateways that you can use outside your provider so I will take a look. Slowly we are being moved to RCS however for the rest of the world I don't think they care.

joaomgcd commented 4 years ago

Yeah... I need to try and replicate the code in the Chrome extension cause that's working. I just don't have a way to test it right now :P