joaomgcd / TaskerPluginSample

A library to help speed up building a Tasker plugin
GNU General Public License v3.0
58 stars 23 forks source link

Fix TaskerPluginRunner always using default NotificationProperties #8

Closed jonahwh closed 2 years ago

jonahwh commented 2 years ago

TaskerPluginRunerAction is always calling IntentServiceParallel.startForegroundIfNeeded which calls TaskerPluginRunner.startForegroundIfNeeded(this), which will always use the default value of NotificationProperties.

This fix adds TaskerPluginRunner.startForegroundIfNeeded(intentServiceParallel: IntentServiceParallel), which is called from TaskerPluginRunnerAction to properly use the configured NotificationProperties.

Before: Notification icon is not displayed properly even though it is configured

Screen Shot 2021-09-12 at 5 41 21 PM

After: Notification icon is displayed properly:

Screen Shot 2021-09-12 at 5 40 59 PM