Missing soldiers translation in AOD

[sebhz]

Soldiers fragment is in English only. The "basic" types should be translated at least.

I had a look in the code and this is harder than it looks as the strings are hardcoded in the save file, so if you localize the strings, save the game, change locale and reload the game you will still get the old locale (and no real way to get around this).

Maybe the proper fix is to keep the savefile strings in English and localize only the listadapter when displaying them - for the basic types. I'll have a look at this.

[joaomneto]

Or we can have two separate string lists for the basic types and the custom ones. Speaking of savegame files, I really wanted to re implement the whole savegame feature in JSON. Maybe I should create a ticket for this also.

On Sun, Aug 27, 2017, 20:10 Seb notifications@github.com wrote:

Soldiers fragment is in English only. The "basic" types should be translated at least.

I had a look in the code and this is harder than it looks as the strings are hardcoded in the save file, so if you localize the strings, save the game, change locale and reload the game you will still get the old locale (and no real way to get around this).

Maybe the proper fix is to keep the savefile strings in English and localize only the listadapter when displaying them - for the basic types. I'll have a look at this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joaomneto/TitanCompanion/issues/84, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTNQtRk7Ktn5QoDgJLoMOHqDj1-w2UPks5scb8kgaJpZM4PD413 .

--

João Neto

[sebhz]

JSON sounds good. A bit overkill maybe but at least standard !

Envoyé depuis mon appareil Samsung

-------- Message d'origine -------- De : João Neto notifications@github.com Date : 27/08/2017 21:47 (GMT+01:00) À : joaomneto/TitanCompanion TitanCompanion@noreply.github.com Cc : Seb seb@zyglute.fr, Assign assign@noreply.github.com Objet : Re: [joaomneto/TitanCompanion] Missing soldiers translation in AOD   (#84)

Or we can have two separate string lists for the basic types and the custom

ones. Speaking of savegame files, I really wanted to re implement the whole

savegame feature in JSON. Maybe I should create a ticket for this also.

On Sun, Aug 27, 2017, 20:10 Seb notifications@github.com wrote:

Soldiers fragment is in English only. The "basic" types should be

translated at least.

I had a look in the code and this is harder than it looks as the strings

are hardcoded in the save file, so if you localize the strings, save the

game, change locale and reload the game you will still get the old locale

(and no real way to get around this).

Maybe the proper fix is to keep the savefile strings in English and

localize only the listadapter when displaying them - for the basic types.

I'll have a look at this.

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub

https://github.com/joaomneto/TitanCompanion/issues/84, or mute the

thread

https://github.com/notifications/unsubscribe-auth/AFTNQtRk7Ktn5QoDgJLoMOHqDj1-w2UPks5scb8kgaJpZM4PD413

.

--

João Neto

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joaomneto/TitanCompanion","title":"joaomneto/TitanCompanion","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joaomneto/TitanCompanion"}},"updates":{"snippets":[{"icon":"PERSON","message":"@joaomneto in #84: Or we can have two separate string lists for the basic types and the custom\nones. Speaking of savegame files, I really wanted to re implement the whole\nsavegame feature in JSON. Maybe I should create a ticket for this also.\n\nOn Sun, Aug 27, 2017, 20:10 Seb \u003cnotifications@github.com\u003e wrote:\n\n\u003e Soldiers fragment is in English only. The \"basic\" types should be\n\u003e translated at least.\n\u003e\n\u003e I had a look in the code and this is harder than it looks as the strings\n\u003e are hardcoded in the save file, so if you localize the strings, save the\n\u003e game, change locale and reload the game you will still get the old locale\n\u003e (and no real way to get around this).\n\u003e\n\u003e Maybe the proper fix is to keep the savefile strings in English and\n\u003e localize only the listadapter when displaying them - for the basic types.\n\u003e I'll have a look at this.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/joaomneto/TitanCompanion/issues/84\u003e, or mute the\n\u003e thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/AFTNQtRk7Ktn5QoDgJLoMOHqDj1-w2UPks5scb8kgaJpZM4PD413\u003e\n\u003e .\n\u003e\n-- \n\nJoão Neto\n"}],"action":{"name":"View Issue","url":"https://github.com/joaomneto/TitanCompanion/issues/84#issuecomment-325220023"}}}

[sebhz]

Losing my way in the multiple layers of save/restore and adapter. Better you handle it :-)

[joaomneto]

Sure! I'll take care of it! Should've commented the code. 😆

Sent from my OnePlus ONEPLUS A3003 using FastHub

[sebhz]

Actually I think I managed to work my way around it eventually. I'll make some more checks and will issue a pull request, probably tomorrow !

[sebhz]

Forget it, still not working. I throw the towel !

[joaomneto]

Hi Seb, can you confirm to me the translation for the standard army types in french:

<string name="warriors">Guerriers</string>
<string name="knights">Chevaliers</string>
<string name="dwarves">Nains</string>
<string name="elves">Elfes</string>

Thanks!

[sebhz]

100% correct. Great translation. I have been a bit busy at work those days and did not have much time for TitanCompanion. I 'll try and get a bit more involved in the coming days.

Envoyé depuis mon appareil Samsung

-------- Message d'origine -------- De : João Neto notifications@github.com Date : 13/09/2017 09:20 (GMT+01:00) À : joaomneto/TitanCompanion TitanCompanion@noreply.github.com Cc : Seb seb@zyglute.fr, Assign assign@noreply.github.com Objet : Re: [joaomneto/TitanCompanion] Missing soldiers translation in AOD   (#84)

Hi Seb, can you confirm to me the translation for the standard army types in french:

Guerriers Chevaliers Nains Elfes

Thanks!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/joaomneto/TitanCompanion","title":"joaomneto/TitanCompanion","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/joaomneto/TitanCompanion"}},"updates":{"snippets":[{"icon":"PERSON","message":"@joaomneto in #84: Hi Seb, can you confirm to me the translation for the standard army types in french:\r\n\r\n \u003cstring name=\"warriors\"\u003eGuerriers\u003c/string\u003e\r\n \u003cstring name=\"knights\"\u003eChevaliers\u003c/string\u003e\r\n \u003cstring name=\"dwarves\"\u003eNains\u003c/string\u003e\r\n \u003cstring name=\"elves\"\u003eElfes\u003c/string\u003e\r\n\r\nThanks!"}],"action":{"name":"View Issue","url":"https://github.com/joaomneto/TitanCompanion/issues/84#issuecomment-329081332"}}}

[joaomneto]

No problem Seb. This is hardly a job, hehe. I've been setting up a jenkins server for CI with automated testing. As soon as its ok ill give you access also.